Repository navigation
fix(core): Avoid stack overflow in FunctionToString on cyclic Proxy prototype chains - #26162
Merged
Merged
Conversation
…rototype chains The patched toString read __sentry_original__ through the prototype chain. When that chain loops back through a Proxy, the lookup never ends and overflows the stack, while native toString returns normally. Only unwrap when the original is an own property, which is how markFunctionWrapped stores it, and fall back to native toString if the lookup throws. The Hono proxies exposed __sentry_original__ only through a get trap, so they also report it as an own property now to keep unwrapping. Fixes #25963 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3079ba0. Configure here.
Contributor
size-limit report 📦Compared: 840f27e (PR test merge using develop at 4c9a4eb) Against: 4c9a4eb (develop) · base run #65205 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 50 successful. See the run.
Successful checks
|
chargome
marked this pull request as ready for review
November 6, 2026 10:28
chargome
requested review from
andreiborza,
isaacs,
msonnb,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team,
isaacs,
msonnb,
mydea and
s1gr1d
November 6, 2026 10:28
andreiborza
approved these changes
Nov 6, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
I'd just inline this and avoid the extra function and the eslint disabling
| unwrappedFunction = originalFunction; | ||
| // `markFunctionWrapped` sets the original as an own property. An inherited lookup could walk a | ||
| // prototype chain that loops through a Proxy and overflow the stack, which native `toString` never does. | ||
| if (SETUP_CLIENTS.has(getClient() as Client) && hasOwnProperty(this, '__sentry_original__')) { |
Member
There was a problem hiding this comment.
Suggested change
| if (SETUP_CLIENTS.has(getClient() as Client) && hasOwnProperty(this, '__sentry_original__')) { | |
| if (SETUP_CLIENTS.has(getClient() as Client) && Object.prototype.hasOwnProperty.call(this, '__sentry_original__')) { |
Member
Author
There was a problem hiding this comment.
This brings back the exact issue we gave as the reason for closing #25964
Comment on lines
+22
to
+26
| // eslint-disable-next-line @typescript-eslint/unbound-method | ||
| const hasOwnProperty = Function.prototype.call.bind(Object.prototype.hasOwnProperty) as ( | ||
| obj: unknown, | ||
| key: PropertyKey, | ||
| ) => boolean; |
Member
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line @typescript-eslint/unbound-method | |
| const hasOwnProperty = Function.prototype.call.bind(Object.prototype.hasOwnProperty) as ( | |
| obj: unknown, | |
| key: PropertyKey, | |
| ) => boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The patched
toStringlooked up__sentry_original__through the prototype chain. If that chain loops through a Proxy, the lookup overflows the stack, while nativetoStringworks fine. We now only read it when it's an own property, which is wheremarkFunctionWrappedputs it.The Hono proxies only exposed it through a
gettrap, so they now report it as an own property too.Closes #25963